Centralize Ruby Version to .ruby-version
#345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenny
reviewed
Mar 19, 2024
| @@ -2,7 +2,6 @@ inherit_gem: | |||
| rubocop-shopify: rubocop.yml | |||
|
|
|||
| AllCops: | |||
| TargetRubyVersion: 2.7 | |||
There was a problem hiding this comment.
I think we need to bump Rubocop to 1.61.0 in order for this to work https://github.com/Shopify/erb-lint/blob/main/Gemfile.lock#L78
|
I think we can also remove the ruby version here https://github.com/Shopify/erb-lint/blob/main/.github/workflows/linting.yml#L12 since GA will read from |
The `.ruby-version` file is the ecosystem standard for defining a Ruby version. This PR adds the `.ruby-version` file, ensures a `required_ruby_version` is set, and removes all other references to Ruby in this repository, aligning it with the standard. > [!IMPORTANT] > Please verify the following before merging: Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant: - [ ] `.ruby-version` file is present with the correct Ruby version defined - [ ] A `required_ruby_version` in your gemspec is set - [ ] There is no Ruby version present in the `dev.yml` Ruby task (before: `- ruby: x.x.x`, after: `- ruby`) - [ ] There is no Ruby version/requirement referenced in the `Gemfile` (no lines with `ruby <some-version>`) - [ ] A `Gemfile.lock` is built with the defined Ruby version - [ ] The version of Rubocop installed is 1.61.0 or greater - [ ] There is no `TargetRubyVersion` defined in `rubocop.yml` - [ ] There is no Ruby argument present in `ruby/setup-ruby` Github Actions that do **not** run on a Ruby matrix (no lines with `ruby-version: “x.x”`) This PR will be merged if there isn't any activity after 4 weeks.
Old versions of rubocop read the ruby version from .ruby-version first. We made the change upstream which is not captured in versions of rubocop (< 0.87). Upstream commit: rubocop/rubocop@02b2c3a Co-authored-by: Étienne Barrié <etienne.barrie@shopify.com>
george-ma
force-pushed
the
centralize_ruby_version-v2
branch
from
ecfebbf
to
6af65c5
Compare
george-ma
force-pushed
the
centralize_ruby_version-v2
branch
3 times, most recently
from
51386f8
to
844dc6f
Compare
Ignore the .intersect? autocorrect
george-ma
force-pushed
the
centralize_ruby_version-v2
branch
from
844dc6f
to
aee9cbe
Compare
george-ma
force-pushed
the
centralize_ruby_version-v2
branch
2 times, most recently
from
55df99e
to
0881563
Compare
jenshenny
reviewed
Apr 2, 2024
george-ma
force-pushed
the
centralize_ruby_version-v2
branch
from
309ff45
to
e919ba5
Compare
jenshenny
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, ensures arequired_ruby_versionis set, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version definedrequired_ruby_versionin your gemspec is setdev.ymlRuby task (before:- ruby: x.x.x, after:- ruby)Gemfile(no lines withruby <some-version>)Gemfile.lockis built with the defined Ruby versionTargetRubyVersiondefined inrubocop.ymlruby/setup-rubyGithub Actions that do not run on a Ruby matrix (no lines withruby-version: “x.x”)This PR will be merged if there isn't any activity after 4 weeks.