Add support for using erb_lint in inline config comments
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have signed the CLA! |
george-ma
reviewed
Oct 17, 2024
There was a problem hiding this comment.
Thank you! 🎉 aware that this PR adds support for both, we should probably update the README here https://github.com/Shopify/erb_lint?tab=readme-ov-file#disable-rule-at-offense-level to the preferred default (erb_lint) LGTM otherwise!
|
@george-ma OK sure, done! Thanks! |
george-ma
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On updating to
0.7.0and the changes introduced by #360, I was a little surprised to find that the magic inline comment forerb_lintwas still onlyerblintThis PR adds support for
erb_lint, egerb_lint:disable (...)I believe this furthers the consolidation on
erb_lintas the canonical naming of the tool.Let me know if there is anything else this needs.
Thanks for
erb_lint!