This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
adds necessary to shopify/jest/no-vague-terms
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoodForOneFare
approved these changes
May 15, 2019
| @@ -142,7 +142,53 @@ ruleTester.run('no-vague-titles', rule, { | |||
| ], | |||
| invalid: [ | |||
| { | |||
| code: "it('properly should correcly appropriate all')", | |||
| code: | |||
| "it('properly should correcly appropriate all descriptive necessary')", | |||
There was a problem hiding this comment.
Not sure what my original thinking was... probably that they all error together are listed properly in the error message. Going to leave it for now.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍑