Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Add prefer-pascal-case-enums rule #96

Merged
merged 2 commits into from
Jun 2, 2018
Merged

Add prefer-pascal-case-enums rule #96

merged 2 commits into from
Jun 2, 2018

Conversation

cartogram
Copy link
Contributor

Closes #78

@cartogram cartogram force-pushed the prefer-pascal-case-enums branch 2 times, most recently from ffbab5b to a637a44 Compare May 27, 2018 20:55
lemonmade
lemonmade approved these changes May 27, 2018
View reviewed changes
Copy link
Member

@lemonmade lemonmade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! You probably need to add the configuration for this to shopify/ typescript configs, and link to this rule from the main README

docs/rules/prefer-pascal-case-enums.md Outdated

Examples of **correct** code for this rule:

```js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts

@cartogram cartogram merged commit d0f0808 into master Jun 2, 2018
@cartogram cartogram deleted the prefer-pascal-case-enums branch June 2, 2018 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lemonmade lemonmade lemonmade approved these changes

@GoodForOneFare GoodForOneFare Awaiting requested review from GoodForOneFare

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartogram @lemonmade @gmcgibbon