Skip to content

Commit

Permalink
Fix Android RN 0.73 namespace requirement (#1216)
Browse files Browse the repository at this point in the history
* Fix Android Gradle Plugin error >= 8.x.x

* update changelog

---------

Co-authored-by: Talha Naqvi <naqvitalha@gmail.com>
  • Loading branch information
gasolin and naqvitalha authored Jun 19, 2024
1 parent 029fd40 commit b9fc9e0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ and adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
- https://github.com/Shopify/flash-list/pull/1076
- Fix stale reference to onScroll and onLoad
- https://github.com/Shopify/flash-list/pull/1112
- Fix Android RN 0.73 namespace requirement
- https://github.com/Shopify/flash-list/pull/1216
- New architecture support
- https://github.com/Shopify/flash-list/pull/550
- Upgrade recyclerlistview to v4.2.1
Expand Down
5 changes: 5 additions & 0 deletions android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@ android {
compileSdkVersion _compileSdkVersion
buildToolsVersion _buildToolsVersion

// Conditional for compatibility with AGP <4.2.
if (project.android.hasProperty("namespace")) {
namespace = "com.shopify.reactnative.flash_list"
}

compileOptions {
sourceCompatibility JavaVersion.VERSION_1_8
targetCompatibility JavaVersion.VERSION_1_8
Expand Down

0 comments on commit b9fc9e0

Please sign in to comment.