Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fixture app to RN 0.72 #1076

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Bump fixture app to RN 0.72 #1076

merged 2 commits into from
Mar 19, 2024

Conversation

gvarandas
Copy link
Contributor

@gvarandas gvarandas commented Feb 26, 2024

Description

Updates the fixture app to react-native@0.72.10.

In addition to that, this PR also:

@shopify/flash-list

  • Updates the devDependency RN version which is used by @shopify/flash-list to the same version
  • Updates @quilted/react-testing to 0.5.27 (so it can run with React 18)

Fixture app

  • Updates several dependencies so they're compatible with RN 72.
  • Updates the detox setup to accommodate the version 20 API changes.
  • Updates all e2e screenshots to run against an iPhone 14

Note

This PR doesn't update the web-app Expo fixture, as that is a beast of its own. I'll follow up with a PR for that.

Reviewers’ hat-rack 🎩

  • Build the app locally for Android and iOS
  • Confirm that running the fixture app works as expected

Screenshots or videos (if needed)

No visual changes are expected.

Checklist

@gvarandas gvarandas force-pushed the chore/update-fixture-app branch 5 times, most recently from c26a9e3 to 99c0464 Compare March 15, 2024 19:44
@gvarandas gvarandas self-assigned this Mar 15, 2024
@gvarandas gvarandas marked this pull request as ready for review March 18, 2024 20:13
@naqvitalha naqvitalha merged commit 39dc134 into main Mar 19, 2024
12 checks passed
@naqvitalha naqvitalha deleted the chore/update-fixture-app branch March 19, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants