Centralize Ruby Version to .ruby-version
#1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshenny
force-pushed
the
centralize_ruby_version
branch
from
d4bb31b
to
c2e5902
Compare
jenshenny
commented
Apr 10, 2024
| @@ -7,7 +7,6 @@ on: | |||
| pull_request: | |||
|
|
|||
| env: | |||
| RUBY_VERSION: 3.0.3 | |||
There was a problem hiding this comment.
Reads from .ruby-version file
gvarandas
approved these changes
May 7, 2024
gvarandas
force-pushed
the
centralize_ruby_version
branch
from
c2e5902
to
36ea703
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
The
.ruby-versionfile is the ecosystem standard for defining a Ruby version. This PR adds the.ruby-versionfile, and removes all other references to Ruby in this repository, aligning it with the standard.What should reviewers focus on?
Important
Please verify the following before merging:
Verify that the changes in the PR meets the following requirements or adjust manually to make it compliant:
.ruby-versionfile is present with the correct Ruby version defineddev.ymlRuby task (before:- ruby: x.x.x, after:- ruby)Gemfile(no lines withruby <some-version>)Gemfile.lockis built with the defined Ruby versionTargetRubyVersiondefined inrubocop.ymlruby/setup-rubyGithub Actions (no lines withruby-version: “x.x”)Please merge this PR if it looks good, this PR will be merged if there isn't any activity after 4 weeks.