Cleanup pending timers after unmounting a component #1159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@retyui thank you for spotting this, can you please elaborate on what other memory leaks you have detected? |
|
I have signed the CLA! |
I found in @xaaf/aaf-rn-sdk, those are not related to the |
|
@naqvitalha Can you review it ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to identify pending timers after unmounting components in tests, I use a unique Jest script on the project (to prevent any memory leaks)
And today it has detected one more in a
node_modules/@shopify/flash-list/src/viewability/ViewabilityHelper.tsfile