Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flex prop to contentContainerStyle #1206

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SzymonGonet
Copy link

@SzymonGonet SzymonGonet commented May 22, 2024

Description

Fixes (issue #221 #848 #858 #517)

We wanted to adjust ListEmptyComponent which was impossible without modifying the flex property of content container.

Checklist

Co-authored-by: Bartosz Szar <szarbartosz@gmail.com>
@SzymonGonet
Copy link
Author

I have signed the CLA!

@Rohit3523
Copy link

Any update?

@domleboss97
Copy link

Any update on this?

@amorino
Copy link

amorino commented Jul 9, 2024

Please, include this change. Styling ListEmptyComponent with something centered without this is imposible without having flex.

@shuffledex
Copy link

Please include this improvement quickly! It is currently very annoying to have to add external logic for it to look correct visually

@ice-cap0
Copy link

ice-cap0 commented Aug 7, 2024

yes please

@eliottishak
Copy link

Bumping this

@ursnj
Copy link

ursnj commented Aug 22, 2024

Any luck with this ?

@ice-cap0
Copy link

what's the hold up?

@thebiltheory
Copy link

thebiltheory commented Aug 29, 2024

@Shopify please?

@southkeys
Copy link

ding

@ibovegar
Copy link

Same issue here!

@ice-cap0
Copy link

pretty please?

@alexandre1921
Copy link

please?

@nonnapopoa
Copy link

Guys, if you agree with the changes, please approve them instead of spamming the issue.

2024-10-23 at 10 17 49@2x

Copy link

@eliottishak eliottishak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@Nazim-hasan Nazim-hasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice-cap0
Copy link

What's the holdup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.