Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict tsconfig #181

Merged
merged 3 commits into from
Mar 15, 2022
Merged

Strict tsconfig #181

merged 3 commits into from
Mar 15, 2022

Conversation

fortmarek
Copy link
Contributor

Description

As we are currently releasing the library as untranspiled, we should be as strict as possible in our tsconfig. This PR changes some of the rules to true (especially implicitAny) and fixes any violations of the newly turned on rules.

Reviewers’ hat-rack 🎩

  • The CI passing should be enough, you optionally can try running it locally

Screenshots or videos (if needed)

Checklist

@fortmarek fortmarek merged commit eb741ed into main Mar 15, 2022
@fortmarek fortmarek deleted the strict-tsconfig branch March 15, 2022 09:08
@naqvitalha
Copy link
Collaborator

@fortmarek Right now we're not publishing untranspiled code. I changed it (we discussed this in the morning meeting). Have we really thought enough about this approach for flash-list or other libraries? I'm not sure if it's the best idea for e.g, TS has opinionated configs as well like noImplicitReturns. If someone uses those build will still break.

@fortmarek
Copy link
Contributor Author

Have we really thought enough about this approach for flash-list or other libraries? I'm not sure if it's the best idea for e.g, TS has opinionated configs as well like noImplicitReturns. If someone uses those build will still break.

Yeah, I forgot we had already changed it. We definitely should default to transpiled build and possibly offer a non-transpiled version if developers would want it. Having stricter tsconfig won't hurt, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants