Horizontal inversion #520
Merged
Horizontal inversion #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naqvitalha
changed the base branch from
fix-footer-layout
to
scrollToImprovements
ElviraBurchik
approved these changes
Jul 11, 2022
Co-authored-by: Elvira Burchik <elviraburchik@gmail.com>
|
Tested this in my closed-source app. It is working correctly on iOS. On Android, it works when the app locale is a ltr language but is broken when switching to an rtl language. The cells appear to be there because the viewability callback is working correctly but the contents of the cells are missing. I am investigating further. |
Co-authored-by: Elvira Burchik <elviraburchik@gmail.com>
2 tasks
* Update rlv to v4.1.0 * change to 4.1.1
|
Hey @mmmoussa 👋 Could you send us reproduction steps? Ideally, in the fixture app if at all possible 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #512
In horizontal mode, inverted mode should be using scaleX transform. It was being skipped in current implementation.
Checklist