Support withCache in debug-network for workerd
#1438
Conversation
| }; | ||
|
|
||
| function getHeader(key: string, request?: CrossRuntimeRequest) { |
There was a problem hiding this comment.
Isn't request just type Request?
There was a problem hiding this comment.
In Oxygen yes but in Node environments they will be passing IncomingMessage (import type {IncomingMessage} from 'node:http'), I think? And the headers there doesn't have a get function, you just read like in an object.
I assume Bun and Deno probably have similar APIs for requests, either Web-like or Node-like, but maybe with different type name.
| @@ -13,7 +13,8 @@ export default { | |||
| const cache = await caches.open('my-cms'); | |||
| const withCache = createWithCache({ | |||
| cache, | |||
| waitUntil: executionContext.waitUntil, | |||
| waitUntil: executionContext.waitUntil.bind(executionContext), | |||
There was a problem hiding this comment.
Are we losing this context without the bind?
There was a problem hiding this comment.
Yes, we already use .bind in all our templates so I just updated it here as well.
Actually, I just remembered there's another constraint in This is also kind of true for the |
We can't use
AsyncLocalStoragein Workerd to pass downrequest-idand other information. This PR adds new parameters tocreateWithCacheto manually pass the required information down so that we can show calls towithCachein/debug-network.Currently passing
requestbut we can change it toheadersor something else. Waiting on another conversation before deciding the final API.