General fixes before releasing #1974
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as off-topic.
This comment was marked as off-topic.
| if (isPrerelease || /^[a-z]+$/i.test(currentVersion)) { | ||
| // Skip prereleases or versions like 'next' or 'latest' |
There was a problem hiding this comment.
Using next as the version in package.json made this function throw cc @juanpprieto
There was a problem hiding this comment.
It would be really nice to make it work with the next release. Even if we don't have all the fancy ui with what's changed. Just making it easy to upgrade an existing project to next seems to be a good idea.
| const eslintrcPath = joinPath(projectDir, '.eslintrc.js'); | ||
| let eslintrc = await readFile(eslintrcPath); | ||
| const {filepath = joinPath(projectDir, '.eslintrc.cjs')} = | ||
| await findFileWithExtension(projectDir, '.eslintrc', ['cjs', 'js']); |
There was a problem hiding this comment.
We are now using .cjs extension in Vite projects because they are "type": "module".
We should update to eslint@9 eventually and start using the new convention (eslint.config.js) but I'm not sure if the rest of the Shopify eslint configs we have are compatible.
| @@ -66,7 +66,8 @@ | |||
| "@shopify/hydrogen-react": "2024.4.0", | |||
| "content-security-policy-builder": "^2.1.1", | |||
| "type-fest": "^4.5.0", | |||
| "source-map-support": "^0.5.21" | |||
| "source-map-support": "^0.5.21", | |||
| "use-resize-observer": "^9.1.0" | |||
There was a problem hiding this comment.
Unfortunate but we need to add this dependency for /subrequest-profiler to work here, since the virtual routes are now provided in the Hydrogen package.
We should make a PR to this package and have them publish an UMD version so that we don't need to do this...
| optimizeDeps: { | ||
| include: ['@shopify/hydrogen'], | ||
| }, |
There was a problem hiding this comment.
I'll be honest and I don't quite understand what's going on here. It seems vite automatically recognizes the mono repo and does not pre-bundle @shopify/hydrogen dependencies. include forces them to be pre-bundled. How does that affect initial reload?
There was a problem hiding this comment.
Vite decides to optimize Hydrogen (I'm not really sure why) when it's used outside of our monorepo. You can see this in the demo-store:
This just lets Vite find the dependency and optimize it earlier to avoid the initial refresh.
templates/skeleton/.npmrc
Outdated
| public-hoist-pattern[]=cookie | ||
| public-hoist-pattern[]=set-cookie-parser | ||
| public-hoist-pattern[]=content-security-policy-builder |
There was a problem hiding this comment.
Reading about public-hoist-pattern and I'm curious to know the error you encountered to know that these needed to get hoisted
There was a problem hiding this comment.
It's this issue: #1834 (comment)
Vite can't find cookie to optimize it even if we tell it to do it. The reason is that if you check node_modules/cookie, it's not there in PNPM. It is in node_modules/.pnpm/node_modules/cookie instead, but Vite doesn't know that.
This change forces pnpm to hoist cookie to node_modules/cookie so that Vite can find it.
Check the commits separately.