Skip to content
This repository has been archived by the owner on Apr 27, 2021. It is now read-only.

[WIP] Add CRD and controller logic #209

Open
wants to merge 2 commits into
base: lua-plugin-manager
Choose a base branch
from

Conversation

alexkursell
Copy link

@alexkursell alexkursell commented Apr 3, 2019

This adds the crd definition, generated client libraries, and the crd subscription logic.

Right now it isn't working. It will read all of the crd definitions in the cluster at controller startup, but it fails to watch for any changes after that. I haven't figured this out yet.

Once I've gotten that working, I have to add hooking into @wayt's download code and sending updates through the unix socket to lua. I also still have to add the vars field to the CRD

Alex Kursell added 2 commits April 3, 2019 16:46
}

// custom spec
type IngressNginxPluginSpec struct {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the point of a CRD for this definition. If we are just going to store base64 definition of the plugin, then using a configmap is a more proper solution than a custom CRD

@aledbf
Copy link

aledbf commented Apr 3, 2019

@alexkursell if you use kubebuilder to add a custom type, the boilerplate you need to write is less than half this PR.

@aledbf
Copy link

aledbf commented Apr 3, 2019

@alexkursell not sure if you are aware of the limits but an object cannot be more than 1MB in Kubernetes (not sure what kind of plugin could require this)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants