This repository has been archived by the owner on Apr 27, 2021. It is now read-only.
[skip ci] [wip] optional ewma monitoring using statsd #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElvinEfendi
force-pushed
the
ewma-monitoring
branch
from
b0b3b0c to
d5775b1
Compare
ElvinEfendi
commented
Jul 3, 2019
| for _, endpoint in ipairs(self.peers) do | ||
| local endpoint_string = endpoint.address .. ":" .. endpoint.port | ||
| local ewma = get_or_update_ewma(endpoint_string, 0, false) | ||
| statsd.gauge(STATSD_BALANCER_EWMA_VALUE, ewma, { endpoint_string = endpoint_string, backend_name = backend_name }) |
There was a problem hiding this comment.
Cardinality will be an issue here since we are tagging by upstream identifier which constantly changes.
I wonder if we should just use logging for this - we can attach EWMA score of picked upstream to every request log. That way we can see how EWMA score of a particular upstream changes over time. The shortcoming of this is that we have to have requests to get the scores - but I think this is acceptable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: