Fixed the URL link which led users to a HTTP 404. #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result when loading the URL link from before |
mdentremont
reviewed
Aug 8, 2022
| @@ -1,6 +1,6 @@ | |||
| # `import {React} from 'Shopify'` | |||
|
|
|||
| This guide provides a few guidelines on writing sensible React. Many of these rules are enforced by our [shared ESLint configuration](../packages/eslint-plugin-shopify), which makes use of the excellent [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) project. | |||
| This guide provides a few guidelines on writing sensible React. Many of these rules are enforced by our [shared ESLint configuration](../packages/eslint-plugin-shopify), which makes use of the excellent [eslint-plugin-react](https://github.com/Shopify/web-configs/tree/main/packages/eslint-plugin) project. | |||
There was a problem hiding this comment.
The old URL no longer gives a 404 - but it does redirect.
Should we instead change the URL to:
Suggested change
| This guide provides a few guidelines on writing sensible React. Many of these rules are enforced by our [shared ESLint configuration](../packages/eslint-plugin-shopify), which makes use of the excellent [eslint-plugin-react](https://github.com/Shopify/web-configs/tree/main/packages/eslint-plugin) project. | |
| This guide provides a few guidelines on writing sensible React. Many of these rules are enforced by our [shared ESLint configuration](../packages/eslint-plugin-shopify), which makes use of the excellent [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react) project. |
There was a problem hiding this comment.
What's the difference between the 2 repositories?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was going through the docs for the code along activity related to React and observed that the link for the shared ESLint configuration at Shopify was broken. After doing some digging, I found out where it was located and wanted to help by fixing the link :)