Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Secrets as resources: more review feedback #438

Merged
merged 5 commits into from
Mar 1, 2019
Merged

Secrets as resources: more review feedback #438

merged 5 commits into from
Mar 1, 2019

Conversation

benlangfeld
Copy link
Contributor

No description provided.

@benlangfeld benlangfeld force-pushed the secrets-as-resources-more-review-feedback branch from da575af to aab294c Compare March 1, 2019 19:57
@benlangfeld benlangfeld marked this pull request as ready for review March 1, 2019 19:58
@benlangfeld benlangfeld mentioned this pull request Mar 1, 2019
Merged
@benlangfeld benlangfeld force-pushed the secrets-as-resources-more-review-feedback branch from aab294c to 97a4fd3 Compare March 1, 2019 21:01
KnVerey
KnVerey reviewed Mar 1, 2019
View reviewed changes
lib/kubernetes-deploy/deploy_task.rb Outdated
# Hide the template contents in case it has senitive information
record_invalid_template(err: f[:err], filename: f[:filename], content: nil)
# Hide the error and template contents in case it has senitive information
record_invalid_template(err: "SUPRESSED FOR SECURITY", filename: f[:filename], content: nil)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo SUPRESSED -> SUPPRESSED

@KnVerey
Copy link
Contributor

KnVerey commented Mar 1, 2019

Triggered CI on 038ab18fc380589789eb176626ba8a6b9f4937a6

@KnVerey
Copy link
Contributor

KnVerey commented Mar 1, 2019

Two failures:

Error:
KubernetesDeployTest#test_pruning_works:
ArgumentError: wrong number of arguments (given 1, expected 0)
    /usr/src/app/test/helpers/fixture_sets/hello_cloud.rb:119:in `assert_secret_present'
    /usr/src/app/test/helpers/fixture_sets/hello_cloud.rb:120:in `assert_secret_present'
    /usr/src/app/test/helpers/fixture_sets/hello_cloud.rb:24:in `assert_all_up'
    /usr/src/app/test/integration/kubernetes_deploy_test.rb:86:in `test_pruning_works'

Error:
KubernetesDeployTest#test_full_hello_cloud_set_deploy_succeeds:
ArgumentError: wrong number of arguments (given 1, expected 0)
    /usr/src/app/test/helpers/fixture_sets/hello_cloud.rb:119:in `assert_secret_present'
    /usr/src/app/test/helpers/fixture_sets/hello_cloud.rb:120:in `assert_secret_present'
    /usr/src/app/test/helpers/fixture_sets/hello_cloud.rb:24:in `assert_all_up'
    /usr/src/app/test/integration/kubernetes_deploy_test.rb:8:in `test_full_hello_cloud_set_deploy_succeeds'

@benlangfeld benlangfeld force-pushed the secrets-as-resources-more-review-feedback branch from 038ab18 to 16f6411 Compare March 1, 2019 21:27
@benlangfeld
Copy link
Contributor Author

@KnVerey Apologies, was in a rush to comply with a review comment and that silly mistake slipped in. Resolved.

@KnVerey KnVerey merged commit 022a78f into Shopify:secrets-as-resources Mar 1, 2019
@benlangfeld benlangfeld deleted the secrets-as-resources-more-review-feedback branch March 1, 2019 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KnVerey KnVerey KnVerey left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benlangfeld @KnVerey