Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloudsql hardcoded resource #680

Merged
merged 2 commits into from
Jan 29, 2020
Merged

Remove cloudsql hardcoded resource #680

merged 2 commits into from
Jan 29, 2020

Conversation

karanthukral
Copy link
Contributor

What are you trying to accomplish with this PR?

  • Remove hardcoded cloudsql class since it has been replaced to start using rollout conditions

How is this accomplished?

  • Removing hardcoded references to cloudsql

What could go wrong?

  • Cloudsql deploys fail or skip verification

cc/ @timothysmith0609 @KnVerey @dturn @Shopify/app-mobility

Copy link
Contributor

@KnVerey KnVerey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Finally, they're all gone! 🔥 🔥 🔥

Copy link
Contributor

@dturn dturn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@karanthukral karanthukral merged commit 2d887a8 into master Jan 29, 2020
@karanthukral karanthukral deleted the remove-cloudsql branch January 29, 2020 17:37
@timothysmith0609 timothysmith0609 temporarily deployed to rubygems February 25, 2020 18:04 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants