Refactor/update attempts kubectl apply #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me except for the linter error in CI. Are you able to investigate that problem? |
|
Rubocop works fine locally, I'm unsure why it's creating that error |
|
Ah, ok I'll take a look at fixing that, then. Sorry about that |
|
cc @Shopify/pipeline |
ayatsynych
approved these changes
Sep 24, 2020
timothysmith0609
approved these changes
Sep 24, 2020
Updated rubocop using bundlelock.
Use method delegate rather than ivars.
Allow specifying a kubeconfig per task in the internal API
Refactor/attempts number and logs
|
If you rebase with master, you'll get the rubocop changes/fixes. |
|
I rebased it! just waiting for CI pass🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing context deadline issues associated with the apply command
Increasing the number of attempts on the apply command will not interfere with the syncing of resources I believe, as the resource watcher is initiated after the apply command and begins syncing here. As well any apply failures will be caught here reaching a DeploymentError before a sync.
The Kubectl apply command is also idempotent, should be safe to retry.