Ensure predeploy deploy timeouts actually raise a timeout error, not … #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothysmith0609
requested review from
JamesOwenHall and
jpfourny
and removed request for
a team
jpfourny
approved these changes
Feb 18, 2022
I think we want to capture #873 in the next update so we don't need to bump the version just yet |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Predeploying priority resourcesphase can only raise aFatalDeploymentError. This is causing some pain during cluster bootstrap, as some priority resources are triggering timeout conditions. I don't see why we shouldn't add the ability for this phase to timeout, so I've added it, here.