-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported Kubernetes and Ruby versions from Krane and CI #905
Conversation
Improve readme regarding the versions that are maintained by upstream and versions that we run integration tests. Bump the required tools to match what currently is maintained by upstream Kubernetes and Ruby projects.
@@ -546,77 +546,6 @@ def test_batch_dry_run_apply_success_precludes_individual_resource_dry_run_valid | |||
], in_order: true) | |||
end | |||
|
|||
# Note: After we drop support for K8s 1.21 this test can be removed, since webhooks must be dry-run safe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there matching code that was making this work with <=1.21 that should also be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all this PR needs to be reverted #798 as there are no more sideeffects during dry-run for mutatingwebhook
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#webhook-resources-v122
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverted in 9f1fe2a
and remove duplicate item for k8s 1.23
22dcd73
to
da36068
Compare
c23a810
to
5cdaa8f
Compare
5cdaa8f
to
a15fa06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This deserves an entry in the changelog. Also, do you want to release a new version now or batch them with more changes?
I was thinking to bump soon to a major version to signal the breaking change, and add new changes on top of the new version. |
What are you trying to accomplish with this PR?
How is this accomplished?
✂️
What could go wrong?
Users of unsupported k8s or ruby versions will be stuck in the Krane 2.4.9 version and only get fixes and new features until migrated to newer supported versions.