Skip to content
This repository has been archived by the owner on Oct 30, 2024. It is now read-only.

Update go #581

Merged
merged 5 commits into from
Mar 13, 2024
Merged

Update go #581

merged 5 commits into from
Mar 13, 2024

Conversation

lynnsh
Copy link
Contributor

@lynnsh lynnsh commented Mar 12, 2024

Description

This PR updates Golang version to 1.22.1 and fixes some linter warnings.

Fixes # (issue)

Type of change
  • Bug fix 🐛
How Has This Been Tested?

Running go test ./... and ./test.sh.

Checklist:
  • I have 🎩 my changes (A 🎩 specifically includes pulling down changes, setting them up, and manually testing the changed features and potential side effects to make sure nothing is broken)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • The test coverage did not decrease
  • I have signed the appropriate Contributor License Agreement

github-actions[bot]
github-actions bot reviewed Mar 12, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Please check out our contributing guidelines and sign the CLA.

thepwagner
thepwagner previously approved these changes Mar 12, 2024
View reviewed changes
Copy link
Contributor

@thepwagner thepwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just some ideas to make the next potential bump a little cheaper.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@lynnsh @thepwagner
Update .github/workflows/ci.yml
45d7373 
Co-authored-by: Pete Wagner <1559510+thepwagner@users.noreply.github.com>
@lynnsh @thepwagner
Update Makefile
9a3e0c1 
Co-authored-by: Pete Wagner <1559510+thepwagner@users.noreply.github.com>
@lynnsh @thepwagner
Update README.md
2e7c2f2 
Co-authored-by: Pete Wagner <1559510+thepwagner@users.noreply.github.com>
@lynnsh lynnsh merged commit 7e8696a into main Mar 13, 2024
4 checks passed
@lynnsh lynnsh deleted the update-go branch March 13, 2024 19:27
@BrewTestBot BrewTestBot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@thepwagner thepwagner thepwagner approved these changes

@dani-santos-code dani-santos-code dani-santos-code left review comments

Assignees
No one assigned
Labels
go-modules readme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lynnsh @thepwagner @dani-santos-code