Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade ruby to minimum CLI version #74

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Conversation

mgmanzella
Copy link
Contributor

@mgmanzella mgmanzella commented Oct 24, 2023

Fixes #73

@mgmanzella mgmanzella requested a review from charlespwd October 24, 2023 10:52
@mgmanzella
Copy link
Contributor Author

Not sure how to test this though, @charlespwd do you have something setup already where it would be easy to sanity check this change?

@mgmanzella mgmanzella requested a review from karreiro October 24, 2023 10:53
Copy link
Contributor

@karreiro karreiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @mgmanzella!

@mgmanzella mgmanzella merged commit 8d3d401 into main Oct 24, 2023
5 checks passed
agaudreau1997 added a commit to agaudreau1997/lighthouse-ci-action that referenced this pull request Dec 28, 2023
Upgrade ruby to minimum CLI version (Shopify#74)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Below min version of ruby for CLI used in docker
2 participants