[ComboBox] Use isomorphic layout effect #4018
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
As @BPScott pointed out in #4015 (comment)
useLayoutEffect
will throw a warning during SSR.WHAT is this pull request doing?
This follows the suggestions in this issue conditionally using
useEffect
instead on the server.How to 🎩
Try this in the playground:
Copy-paste this code in
playground/Playground.tsx
:🎩 checklist