Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Switch to Github Actions #1693

Merged
merged 8 commits into from
Dec 9, 2020
Merged

Switch to Github Actions #1693

merged 8 commits into from
Dec 9, 2020

Conversation

alexandcote
Copy link
Contributor

Description

Fixes (issue #)

Type of change

  • Patch: Bug (non-breaking change which fixes an issue)
  • Minor: New feature (non-breaking change which adds functionality)
  • Major: Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have added a changelog entry, prefixed by the type of change noted above (Documentation fix and Test update does not need a changelog as we do not publish new version)

@alexandcote alexandcote force-pushed the github_actions branch 3 times, most recently from 9781bee to 795d3e7 Compare December 4, 2020 17:41
@alexandcote alexandcote marked this pull request as ready for review December 4, 2020 17:42
@alexandcote alexandcote changed the base branch from master to 557-allow-rerender-formstate-list-nested December 4, 2020 17:42
@alexandcote alexandcote changed the base branch from 557-allow-rerender-formstate-list-nested to master December 4, 2020 17:42
@alexandcote alexandcote force-pushed the github_actions branch 3 times, most recently from bd0d585 to 5be3e52 Compare December 4, 2020 19:28
mllemango
mllemango reviewed Dec 8, 2020
View reviewed changes
.github/workflows/ruby-ci.yml
- uses: actions/checkout@v2
name: Checkout

- uses: ruby/setup-ruby@v1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using ruby/setup-ruby action over actions/setup-ruby since actions/setup-ruby will be deprecated

mllemango
mllemango reviewed Dec 8, 2020
View reviewed changes
.github/workflows/ruby-ci.yml Outdated
- name: 📦 Install dependencies
run: |
bundle config set ignore_messages true
bundle install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle install --clean ran into various issues, wondering if this is okay

Copy link
Contributor Author

@alexandcote alexandcote Dec 8, 2020 •
edited by marutypes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine 👍 I think we should add --frozen so we are sure the Gemfile is not updated.

Suggested change
bundle install
bundle install --frozen

mllemango
mllemango reviewed Dec 8, 2020
View reviewed changes
.github/workflows/ruby-ci.yml
bundler-cache: true
- name: 📦 Install dependencies
run: |
bundle config set ignore_messages true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignores the post install message ..."HEADS UP! i18n 1.1 changed fallbacks to exclude default locale....", example here

@mllemango
Copy link
Contributor

Will need to edit branch protection to remove the required "continuous-integration/travis-ci" check, and add Github Actions check after this is merged.

@mllemango mllemango requested a review from a team December 8, 2020 16:00
alexandcote
alexandcote commented Dec 8, 2020
View reviewed changes
.github/workflows/node-ci.yml Show resolved Hide resolved
.github/workflows/ruby-ci.yml Show resolved Hide resolved
.github/workflows/ruby-ci.yml Outdated
- name: 📦 Install dependencies
run: |
bundle config set ignore_messages true
bundle install
Copy link
Contributor Author

@alexandcote alexandcote Dec 8, 2020 •
edited by marutypes
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine 👍 I think we should add --frozen so we are sure the Gemfile is not updated.

Suggested change
bundle install
bundle install --frozen

@alexandcote
Copy link
Contributor Author

Thank you @mllemango to take over this PR ❤️

Everything looks 💯 to me ✅

gmcgibbon
gmcgibbon reviewed Dec 8, 2020
View reviewed changes
.github/workflows/node-ci.yml Outdated Show resolved Hide resolved
.github/workflows/ruby-ci.yml Outdated Show resolved Hide resolved
ismail-syed added a commit that referenced this pull request Dec 9, 2020
@ismail-syed
Hack in GitHub Actions from PR #1693 because is hanging
fc6418a
ismail-syed added a commit that referenced this pull request Dec 9, 2020
@ismail-syed
Hack in GitHub Actions from PR #1693 because is hanging
e54cc37
ismail-syed added a commit that referenced this pull request Dec 9, 2020
@ismail-syed
Hack in GitHub Actions from PR #1693 because is hanging
d797ef9
ismail-syed added a commit that referenced this pull request Dec 9, 2020
@ismail-syed
Hack in GitHub Actions from PR #1693 because is hanging
4e479ef
@mllemango mllemango requested a review from gmcgibbon December 9, 2020 16:57
gmcgibbon
gmcgibbon approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@gmcgibbon gmcgibbon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇

@atesgoral atesgoral merged commit a8b32f8 into master Dec 9, 2020
@atesgoral atesgoral deleted the github_actions branch December 9, 2020 19:10
@atesgoral atesgoral mentioned this pull request Dec 9, 2020
Closed
@chrisseaton chrisseaton mentioned this pull request Dec 10, 2020
Merged
@gmcgibbon gmcgibbon temporarily deployed to production December 11, 2020 21:33 Inactive
@marutypes marutypes temporarily deployed to gem February 8, 2021 15:51 Inactive
@ismail-syed ismail-syed deployed to beta-mandatory-extensions March 2, 2021 19:35 Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mllemango mllemango mllemango left review comments

@gmcgibbon gmcgibbon gmcgibbon approved these changes

@atesgoral atesgoral atesgoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexandcote @mllemango @atesgoral @gmcgibbon @marutypes @ismail-syed