Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Expose Surface's width and height #2345

Merged
merged 5 commits into from
Apr 9, 2024
Merged

feat: Expose Surface's width and height #2345

merged 5 commits into from
Apr 9, 2024

Conversation

mrousavy
Copy link
Contributor

@mrousavy mrousavy commented Apr 8, 2024

Exposes surface.width() and surface.height() as well.

wcandillon
wcandillon requested changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@wcandillon wcandillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change in JsiSkImage is orthogonal

@wcandillon wcandillon self-requested a review April 9, 2024 09:28
@mrousavy
Copy link
Contributor Author

mrousavy commented Apr 9, 2024

fixed the lint errors 👍

@wcandillon
Copy link
Contributor

🛳️

@wcandillon wcandillon merged commit 5eeeb80 into Shopify:main Apr 9, 2024
1 check passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcandillon wcandillon wcandillon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrousavy @wcandillon