Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix makeImageFromHardwareBuffer memory leak #2389

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fix: Fix makeImageFromHardwareBuffer memory leak #2389

merged 1 commit into from
Apr 19, 2024

Conversation

mrousavy
Copy link
Contributor

@mrousavy mrousavy commented Apr 19, 2024 •
edited
Loading

Fixes an issue where the memory of the HardwareBuffer OpenGL texture was never freed.

We need to pass the deleter to the SkImage's releaseProc.

cc @rodgomesc

@mrousavy
Copy link
Contributor Author

PR is ready - we tested on an old MI9 T Pro and achieved stable 30 FPS without memory leaks.

@mrousavy mrousavy marked this pull request as ready for review April 19, 2024 12:58
@wcandillon wcandillon self-requested a review April 19, 2024 13:57
@wcandillon
Copy link
Contributor

Thanks for catching this

@wcandillon wcandillon merged commit 61571c3 into Shopify:main Apr 19, 2024
7 checks passed
@github-actions GitHub Actions
Copy link
Contributor

🎉 This PR is included in version 1.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wcandillon wcandillon wcandillon approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrousavy @wcandillon