Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing createElement hook call and Node.textContent bug #281

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

santala
Copy link
Contributor

@santala santala commented Feb 23, 2024

No description provided.

@santala santala changed the title Fix missing createElement hook call Fix missing createElement hook call and Node.textContent bug Feb 26, 2024
@lemonmade
Copy link
Member

Hey @santala, thank you so much for the fixes! Do you mind synchronizing with the origin’s main branch and pushing this branch again? CI steps are not running correctly, and I also did not have Shopify’s CLA action set up for this repo yet. Once you do that, you will likely get a message from the CLA bot with a couple of additional instructions. Sorry for the headache.

@santala
Copy link
Contributor Author

santala commented Feb 29, 2024

@lemonmade sync done. You’re welcome! I came across the bugs while working on support for event handlers in web workers. I have a proof-of-concept for that, but there are some details that need to be discussed, so I’m planning to open an issue for that in the near future (unless you’ve already solved it).

@santala
Copy link
Contributor Author

santala commented Mar 1, 2024

@lemonmade the lint check failed on the .changeset directory. That probably should be excluded from the lint config?

@lemonmade
Copy link
Member

The changesets get consumed into changelog files that are also linted, so I am feeling like it's probably to force the changeset files to be prettier-ified when committed. It is definitely annoying that changesets doesn't try to auto-format the changesets, though :/

@lemonmade lemonmade merged commit c283e41 into Shopify:main Mar 4, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants