Move hooks into Window instance

[olavoasantos]

Summary

The current implementation of the DOM polyfill uses an in memory singleton to manage internal hooks. This results in coupling of the polyfill with the global scope, preventing multiple instances of Window from being created without interfering with each other.

This PR refactors the management of these hooks by scoping them in the Window instance, decoupling the implementation from the global scope.

[lemonmade]

I like this change a lot, thanks for putting it together. I left a few comments but I think this is quite close 👍

[lemonmade]

This is an issue because of us calling setData in the constructor, right? Instead of doing this, could we just assign to this[DATA] directly in the constructor (applying the same stringifying logic implemented above), which avoids this triggering a hook call?

[olavoasantos]

I considered that but that would skip the initial hook call and change the existing behaviour. I'm ok with that but it's a change in the existing behaviour. Alternatively, we can manually set the value via this[DATA] and schedule the hook call within the constructor.

[lemonmade]

I am OK to break this behavior. I think the library is actually broken in a different way here — we expose a createText hook

remote-dom/packages/polyfill/source/hooks.ts

Line 10 in ce50f4b

createText(text: Text, data: string): void;

, which should be used to cover the "initial value of a text node" case, but we don't seem to call that hook anywhere 😬

[olavoasantos]

Whoops haha Should I add setTimeout(() => this[HOOKS]?.createText ...) here then?

[lemonmade]

Looks great, thanks so much for this improvement Olavo!