Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix references after node removal #472

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Fix references after node removal #472

merged 4 commits into from
Oct 29, 2024

Conversation

jakearchibald
Copy link
Contributor

Prior to this:

  • parentNode
  • nextSibling
  • previousSibling
  • nextElementSibling
  • previousElementSibling

…remained set when removing an element from its parent.

I also added node.parentElement.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
henrytao-me
henrytao-me approved these changes Oct 28, 2024
View reviewed changes
Copy link
Member

@henrytao-me henrytao-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎩-ed. LGTM

@jakearchibald jakearchibald merged commit 1473a3c into main Oct 29, 2024
5 checks passed
@shopify-github-actions-access shopify-github-actions-access bot mentioned this pull request Oct 29, 2024
Merged
@henrytao-me henrytao-me deleted the ja/polyfill-fix-remove branch October 29, 2024 12:42
Oleksii20in
Oleksii20in reviewed Dec 15, 2024
View reviewed changes
Copy link

@Oleksii20in Oleksii20in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oleksii20in Oleksii20in Oleksii20in left review comments

@vividviolet vividviolet vividviolet approved these changes

@henrytao-me henrytao-me henrytao-me approved these changes

@developit developit developit approved these changes

@lemonmade lemonmade Awaiting requested review from lemonmade

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jakearchibald @developit @henrytao-me @vividviolet @Oleksii20in