Apply React polyfill directly to globalThis
#492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lemonmade
force-pushed
the
react-polyfill-to-globalThis
branch
from
fc11885 to
b4e67ce
Compare
robin-drexler
approved these changes
Nov 18, 2024
lemonmade
force-pushed
the
react-polyfill-to-globalThis
branch
from
b4e67ce to
deb42fa
Compare
|
I've updated this PR to depend on the changes in #499, where I rolled back the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the React polyfill to apply directly to
globalThis. This fixes a bug that resulted from shipping #470, since the additional polyfills added by@remote-dom/react/polyfill(in particular, the one forHTMLIframeElement) were only being applied to the polyfilledWindowclass, not toglobalThis.