Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add layout props to createText function #262

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

robrechtme
Copy link
Contributor

Description

The RN Text component supports layout styles like flex and maxWidth these are commonly used, especially flex={1} for layouting and therefore useful to be exposed as props.

Reviewers’ hat-rack 🎩

  • [ ]

Screenshots or videos (if needed)

Checklist

@robrechtme
Copy link
Contributor Author

Hi @mattfrances @JoelBesada this one has been open for a while, any chance it can be reviewed? 😇 Thanks!

@mattfrances
Copy link
Contributor

Hi @mattfrances @JoelBesada this one has been open for a while, any chance it can be reviewed? 😇 Thanks!

Hi, thanks for the tag! Are there any use cases where you cannot achieve the same result by adding flex and maxWidth to a parent Box wrapping the Text?

@robrechtme
Copy link
Contributor Author

Hmm not that I can think of actually 🤔 But it wouldn't hurt to expose these, since they are valid styles, no?

@mattfrances
Copy link
Contributor

Hmm not that I can think of actually 🤔 But it wouldn't hurt to expose these, since they are valid styles, no?

Agreed! Please add a changelog entry in the CHANGELOG.md file under the "Next" section and we can get this merged

@AronBe
Copy link

AronBe commented Feb 20, 2024

Hey guys, thanks for your work. Seems like this has been approved some time ago, is it possible to get it merged?

The RN `Text` component supports layout styles like `flex` and `maxWidth` these are commonly used, especially flex={1} for layouting and therefore useful to be exposed as props.
@robrechtme
Copy link
Contributor Author

Hi

Sorry I've forgotten about this. I've added a changelog so this is ready to be merged!

@naqvitalha naqvitalha merged commit cea75f9 into Shopify:master Apr 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants