Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict gem to < Ruby 3.0 #93

Closed
wants to merge 1 commit into from
Closed

Restrict gem to < Ruby 3.0 #93

wants to merge 1 commit into from

Conversation

jahfer
Copy link
Contributor

@jahfer jahfer commented Oct 28, 2021

Until #87 is closed, this gem produces unreliable results under Ruby 3.

Make sure these are checked before submitting your PR — thank you!

  • bin/fmt was successfully run

Until #87 is fixed, this gem produces unreliable results under Ruby 3.
@dylanahsmith
Copy link
Contributor

We are already using rotoscope on ruby 3. The main concern would be with caller_singleton_method? (at least in combination with caller_method_name and call.caller_class_name), but that isn't being used by that use of rotoscope.

@jahfer
Copy link
Contributor Author

jahfer commented Oct 28, 2021

but that isn't being used by that use of rotoscope

Not sure I follow. The script you shared in #87 (comment) suggests to me that the gem currently produces incorrect instance/class attribution when the caller is a C method. #caller_singleton_method? is part of the public API.

@dylanahsmith
Copy link
Contributor

Yes, it is a part of rotoscope's API, but it is only a problem for apps that actually use that method. I mean we are using rotoscope on ruby 3 at Shopify, but without using that method. Adding a ruby version constraint would just block that dependency on rotoscope from being updated.

@jahfer jahfer closed this Oct 29, 2021
@jahfer jahfer deleted the ruby-3-restriction branch October 29, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants