Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing markdown code fence around example #198

Merged
merged 1 commit into from
Feb 6, 2024
Merged

add missing markdown code fence around example #198

merged 1 commit into from
Feb 6, 2024

Conversation

mmenanno
Copy link
Contributor

@mmenanno mmenanno commented Feb 2, 2024

This example was missing the code block fencing around it. So just adding that in.

@mmenanno mmenanno requested a review from a team as a code owner February 2, 2024 01:43
@mmenanno
Copy link
Contributor Author

mmenanno commented Feb 2, 2024

I have signed the CLA!

Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks,

You applied the changes to the generated file.

You'll have to update this file instead: https://github.com/Shopify/rubocop-sorbet/blob/main/lib/rubocop/cop/sorbet/signatures/signature_build_order.rb then run bundle exec rake generate_cops_documentation.

@mmenanno
Copy link
Contributor Author

mmenanno commented Feb 2, 2024

Ahhh there we go, the change was even more subtle, the yard doc comments just needed one more space in front of them to be parsed as code blocks

@mmenanno mmenanno requested a review from Morriar February 2, 2024 13:48
Copy link
Contributor

@Morriar Morriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@Morriar Morriar merged commit 93ecec7 into Shopify:main Feb 6, 2024
6 checks passed
@mmenanno mmenanno deleted the add-missing-code-fence branch February 15, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants