Remove warning from RuboCop in rbi config #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Warning: Sorbet does not support DisabledByDefault parameter. Supported parameters are: - DocumentationBaseURL - DocumentationExtension ``` This is true. Because of Shopify#252, the top-level Sorbet config key now can be present simply by loading the config, which causes RuboCop to do some extra validating. `DisabledByDefault` is already set for all cops at the top anyways.
egiurleo
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is true (except for the part where RuboCop only suggests a subset of valid keys). Because of #252, the top-level Sorbet config key now can be present simply by loading the config, which causes RuboCop to do some extra validating.
DisabledByDefaultis already set for all cops at the top anyways.