Ensure schema link is rendered with column information (#475)

Shopify · Oct 4, 2024 · 23216d1 · 23216d1
1 parent c5043be
commit 23216d1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/lib/ruby_lsp/ruby_lsp_rails/hover.rb b/lib/ruby_lsp/ruby_lsp_rails/hover.rb
@@ -62,8 +62,8 @@ def generate_column_content(name)
         schema_file = model[:schema_file]
 
         @response_builder.push(
-          "[Schema](#{URI::Generic.from_path(path: schema_file)})",
-          category: :links,
+          "[Schema](#{URI::Generic.from_path(path: schema_file)})\n",
+          category: :documentation,
         ) if schema_file
 
         @response_builder.push(

diff --git a/test/ruby_lsp_rails/hover_test.rb b/test/ruby_lsp_rails/hover_test.rb
@@ -35,9 +35,10 @@ class User < ApplicationRecord
           ```
 
           **Definitions**: [fake.rb](file:///fake.rb#L1,1-2,4)
-          [Schema](#{URI::Generic.from_path(path: dummy_root + "/db/schema.rb")})
 
 
+          [Schema](#{URI::Generic.from_path(path: dummy_root + "/db/schema.rb")})
+
           **id**: integer (PK)
 
           **first_name**: string
@@ -83,9 +84,10 @@ class User < ApplicationRecord
           ```
 
           **Definitions**: [fake.rb](file:///fake.rb#L2,3-3,6)
-          [Schema](#{URI::Generic.from_path(path: dummy_root + "/db/schema.rb")})
 
 
+          [Schema](#{URI::Generic.from_path(path: dummy_root + "/db/schema.rb")})
+
           **id**: integer (PK)
 
           **first_name**: string
@@ -128,9 +130,10 @@ class CompositePrimaryKey < ApplicationRecord
           ```
 
           **Definitions**: [fake.rb](file:///fake.rb#L1,1-2,4)
-          [Schema](#{URI::Generic.from_path(path: dummy_root + "/db/schema.rb")})
 
 
+          [Schema](#{URI::Generic.from_path(path: dummy_root + "/db/schema.rb")})
+
           **order_id**: integer (PK)
 
           **product_id**: integer (PK)