Move provider definition to individual requests #1261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morriar
added
bugfix
andyw8
approved these changes
Dec 21, 2023
Some provider definitions require the request's data like constants. Instead of exposing all those to the executor, it's better to define the providers inside the request classes.
st0012
force-pushed
the
extract-provider-logic
branch
from
6a4bded to
5c9d9bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
While working on #1247, I found that we try to access some request's constants directly from the executor for building the providers. I think this is a leaky abstraction and requests should simply have a
providermethod to return the associated options or provider.Implementation
Request.providermethod on request classes that need a providerAutomated Tests
Manual Tests