Rename Request#response to Request#perform #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As @vinistock pointed out, using `#response` seems to imply that the request was already completed before it's called. In ruby-lsp's case, many requests are used in this pattern: ```rb FooRequest.new(args).response ``` In this context, it feels like the computation is done in `FooRequest#initialize` and `#response` is just a getter, which is a bit misleading. So this commit renames `#response` to `#perform` to make it more clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As @vinistock pointed out here, using
#responseseems to imply that the request was already completed before it's called. In ruby-lsp's case, many requests are used in this pattern:In this context, it feels like the computation is done in
FooRequest#initializeand#responseis just a getter, which is a bit misleading.So this PR renames
#responseto#performto make it more clear.Implementation
Renames relevant interfaces and callers.
Automated Tests
Manual Tests