Prevent composed bundle from failing with SSH git sources #2810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @vinistock and the rest of your teammates on |
vinistock
added
server
Graphite App
KaanOzkan
approved these changes
Oct 31, 2024
vinistock
force-pushed
the
10-31-prevent_composed_bundle_from_failing_with_ssh_git_sources
branch
from
22ac487 to
473c9b8
Compare
Yeah, in that scenario, bundle install will fail. With the new experimental launcher mode, we will still be able to launch the server despite that happening and report the problem to the user, but there's not much else that we can do. |
vinistock
deleted the
10-31-prevent_composed_bundle_from_failing_with_ssh_git_sources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #2809
You can use SSH git sources in your Gemfile, which result in a lockfile remote that isn't a valid URI. We need to protect the composed bundle setup from that possibility or else it crashes.
Implementation
Started rescuing URI related errors, which then makes us default to not performing any corrections and just using the exact remote existing in the lockfile.
Automated Tests
Added a test that reproduces the reported issue.