Use field instead of variable for instance variable symbol kinds
#2898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinistock
force-pushed
the
11-21-use_field_instead_of_variable_for_instance_variable_symbol_kinds
branch
from
f41ded1 to
a0de64b
Compare
vinistock
added
server
Graphite App
andyw8
approved these changes
Nov 21, 2024
vinistock
deleted the
11-21-use_field_instead_of_variable_for_instance_variable_symbol_kinds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Very minor thing, but I noticed that we were using the wrong symbol kind for instance variables in document symbols. We use
FIELDeverywhere else, so that it doesn't get confused with other types of variables.Implementation
Changed to
FIELD.Automated Tests
Updated the tests.