Merge pull request #61 from Shopify/disable_explicit_gzip_encoding

disable explicit gzip
Shopify · Apr 23, 2019 · 4698c6e · 4698c6e
2 parents cc5b5d3 + bebabda
commit 4698c6e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/lib/salesforce_chunker/connection.rb b/lib/salesforce_chunker/connection.rb
@@ -21,7 +21,6 @@ def initialize(username: "", password: "", security_token: "", domain: "login",
       @default_headers = {
         "Content-Type": "application/json",
         "X-SFDC-Session": result["sessionId"],
-        "Accept-Encoding": "gzip",
       }
     rescue NoMethodError
       raise ConnectionError, response["Envelope"]["Body"]["Fault"]["faultstring"]

diff --git a/test/lib/connection_test.rb b/test/lib/connection_test.rb
@@ -38,7 +38,6 @@ def test_post_calls_post_with_correct_parameters
     expected_headers = {
       "Content-Type": "application/json",
       "X-SFDC-Session": "3ea96c71f254c3f2e6ce3a2b2b723c87",
-      "Accept-Encoding": "gzip",
     }
     HTTParty.expects(:post).with(expected_url, body: "blah", headers: expected_headers).returns(json_response)
 
@@ -52,7 +51,6 @@ def test_get_json_calls_get_with_correct_parameters
     expected_headers = {
       "Content-Type": "application/json",
       "X-SFDC-Session": "3ea96c71f254c3f2e6ce3a2b2b723c87",
-      "Accept-Encoding": "gzip",
     }
     HTTParty.expects(:get).with(expected_url, headers: expected_headers).returns(json_response)
 
@@ -66,7 +64,6 @@ def test_get_returns_response_object
     expected_headers = {
       "Content-Type": "application/json",
       "X-SFDC-Session": "3ea96c71f254c3f2e6ce3a2b2b723c87",
-      "Accept-Encoding": "gzip",
     }
     HTTParty.expects(:get).with(expected_url, headers: expected_headers).returns(json_response)
 
@@ -79,7 +76,6 @@ def test_headers_can_be_overridden
     expected_headers = {
       "Content-Type": "text/csv",
       "X-SFDC-Session": "3ea96c71f254c3f2e6ce3a2b2b723c87",
-      "Accept-Encoding": "gzip",
       "Foo": "bar",
     }
     HTTParty.expects(:get).with(expected_url, headers: expected_headers).returns(json_response)