Always set ignored_safeties when emergency mode is enabled #1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
actgardner
force-pushed
the
always-set-force
branch
from
0b7668b
to
dd4a22e
Compare
|
Hmm, I worry this would create false positives in github-certification, @casperisfine wdyt? |
Yeah, I had the same worry. I think overall this would be better handled with a boolean deploy variable. I also wonder if that makes sense as an open source feature. |
|
|
Yes, exactly what I had in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're looking for ways to work Binary Authorization breakglass into the existing deploy workflow. One proposal was to trigger breakglass on an emergency deploy (see https://github.com/Shopify/production-registry/pull/245)
A deploy blocked by Binary Authorization may have a green CI status. For this reason, we need to either:
ignored_safetieswhen the Emergency Deploy mode is enabled, even if CI is passingignored_safeties, but which is always set when Emergency Deploy mode is enabledThis PR takes the first approach and changes the behaviour of the existing field.