Move logic to 'proxy.rb' and DRY headers logic

Shopify · Jan 12, 2022 · 2758d51 · 2758d51
1 parent 4ff17ab
commit 2758d51
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/lib/shopify_cli/theme/dev_server/proxy.rb b/lib/shopify_cli/theme/dev_server/proxy.rb
@@ -18,6 +18,7 @@ module DevServer
         "trailer",
         "transfer-encoding",
         "upgrade",
+        "content-security-policy",
       ]
 
       class Proxy

diff --git a/test/shopify-cli/theme/dev_server/proxy_test.rb b/test/shopify-cli/theme/dev_server/proxy_test.rb
@@ -176,11 +176,13 @@ def test_hop_to_hop_headers_are_removed_from_proxied_response
               "Trailer" => 1,
               "Transfer-Encoding" => 1,
               "Upgrade" => 1,
+              "content-security-policy" => 1,
             })
 
           stub_session_id_request
           response = request.get("/")
 
+          assert(response.headers.size.zero?)
           HOP_BY_HOP_HEADERS.each do |header|
             assert(response.headers[header].nil?)
           end