This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Improved extension build output #1737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t6d
force-pushed
the
feature/improved-extension-build-output
branch
3 times, most recently
from
834ea87 to
5d62a77
Compare
t6d
requested review from
a team,
pepicrft and
gonzaloriestra
and removed request for
a team
t6d
force-pushed
the
feature/improved-extension-build-output
branch
from
5d62a77 to
2e2ddd5
Compare
cecyc
approved these changes
Nov 16, 2021
There was a problem hiding this comment.
Looks good to ship after addressing @gonzaloriestra's comment 👍
ESBuild status messages and errors are now directly presented to the user rather than being obfuscated by a generic message.
Co-authored-by: Gonzalo Riestra <gonzalo.riestra@shopify.com>
t6d
force-pushed
the
feature/improved-extension-build-output
branch
from
04bbc4f to
5d92c32
Compare
pepicrft
pushed a commit
that referenced
this pull request
Nov 23, 2021
ESBuild status messages and errors are now directly presented to the user rather than being obfuscated by a generic message. Co-authored-by: Gonzalo Riestra <gonzalo.riestra@shopify.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
To provide more information during
shopify extension build. Instead of using generic messages to report the build status, we now output the messages returned from ESBuild.WHAT is this pull request doing?
The new error and success messages look as follows.
Error case
Success case
How to test your changes?
Update checklist
I've included any post-release steps in the section above.