This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Gracefully handle errors validating the form #1751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: Bugsnag error
Fixes: Bugsnag error
WHY are these changes introduced?
After releasing 2.7.0 I noticed a new error in the app creation flow. After digging into it, I realized we are rescueing from from validation errors and returning a
nil
. Because we try to call a method on that returnednil
value, the execution terminates.WHAT is this pull request doing?
I changed the
node_service
to follow the same approach as therails_service
. If the output from the form isnil
, we return printing the help to the user.How to test your changes?
Try to create an app (e.g.
shopify node create
)Update checklist