This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix tunnel creation for expired anonymous tunnels #1758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #1747
Fixes #952
Fixes #1742
When starting a new tunnel (used from
app serve
), we were reading from the ngrok log the remaining time of the tunnel in order to re-create it when expired. And for some reason now ngrok is not returning that duration, but always0
, making the CLI to think that they are always expired. We have already asked ngrok about that.WHAT is this pull request doing?
For anonymous tunnels, always restart them when calling
start
. The disadvantage is that a new URL will be generated each time (before, the URL only changed every 2h).This is a hotfix to prevent the current problems, but the tunnel management in general should be reviewed.
How to test your changes?
shopify app tunnel start
, without having a ngrok authtoken (which it's stored in~/.ngrok2/ngrok.yml
)Update checklist