This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 201
Fix: Tunnel --PORT parameter not working in Node.js app. #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-phan
requested review from
a team,
hannachen and
gonzaloriestra
and removed request for
a team
November 17, 2021 03:31
ghost
added
the
cla-needed
label
Nov 17, 2021
gonzaloriestra
suggested changes
Nov 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @paul-phan! 👏
Your changes look right. However, we would need a few things:
- Could you sign the Contributor License Agreement (CLA)?
- Add this change to the CHANGELOG.md (Unreleased section)
- Would you mind adding tests for this? I think it would be enough if you add something like
ShopifyCLI::Tunnel.expects(:start).with(@context, port: 5000).returns("https://example.com")
to the tests namedtest_call_when_port_passed
andtest_server_command_when_port_passed
ghost
removed
the
cla-needed
label
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! I've already tested it and it works as expected 👌
There are just a few minor details to be fixed and we can merge it!
Thanks for your suggestion; I've updated it! |
gonzaloriestra
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge 🚀
It will be included in the next release. Thanks!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
After version 2.7.0, we no longer can use a custom port for
ngrok
tunnel. Seem like there was a missing parameter in thenode_service.rb
WHAT is this pull request doing?
Add the
port
parameter to the tunnel start function.How to test your changes?
For Node.js project, assume you want to tunnel the
localhost:3000
.This command should work:
shopify app serve --PORT 3000
Post-release steps
Update checklist