Skip to content
This repository has been archived by the owner on Jun 1, 2023. It is now read-only.

Fix theme serve failing with the --host property #1766

Merged
merged 2 commits into from
Nov 19, 2021
Merged

Fix theme serve failing with the --host property #1766

merged 2 commits into from
Nov 19, 2021

Conversation

karreiro
Copy link
Contributor

@karreiro karreiro commented Nov 17, 2021

Fix theme serve failing with the --host property (#1765) by renaming the parameters from http_bind to host.

WHY are these changes introduced?

This was failing because we were calling DevServer#start in the theme/commands/serve.rb file with the **flags and the names were different.

WHAT is this pull request doing?

This PR renames parameters from http_bind to host.

How to test your changes?

shopify theme serve --host=0.0.0.0

Here's the previous behavior:

Here's how it actual behavior (with this PR applied):

Update checklist

  • I've added a CHANGELOG entry for this PR (if the change is public-facing)
  • I've considered possible cross-platform impacts (Mac, Linux, Windows).
  • I've left the version number as is (we'll handle incrementing this when releasing).
  • I've included any post-release steps in the section above.

@karreiro karreiro requested review from macournoyer, pepicrft, a team and jesalerno84 and removed request for a team November 17, 2021 10:39
Copy link
Contributor

@macournoyer macournoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants