This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Fix hot reload when users update many files "simultaneously" #1830
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Some users rely on tools over their theme (like Webpack) to update multiple files in a very short period of time.
The
message.date.modified
list may contain multiple files in that kind of scenario. However, if the first file of the list doesn't require refreshing the entire page, while the second file does, the changes from the second file are not covered by the hot reload mechanism.WHAT is this pull request doing?
This pull request introduces changes in the
hot-reload.js
module to analyze all modified files instead of considering only the first one (inspired by #1458).How to test your changes?
Download the
reproducer_remove_me.rb
here.Before this PR:
After this PR:
Post-release steps
None.
Update checklist