This repository has been archived by the owner on Jun 1, 2023. It is now read-only.
Ensure correct ngrok version is downloaded for Apple M1 #1831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for installing the proper version of
ngrok when running
shopify app serve
on M1 macs.Specifically, this patch updates the
os
property of the shop-clicontext with a new key
mac_m1
, not justmac
, and updates theDOWNLOAD_URL dictionary.
Fixes #1785
How to test your changes?
Pull down the branch, install it locally, create a new app and try to serve it..
As discussed in the bug, previously the ngrok tunnel step would fail.
Verifying change
The new version is
arm64
based➜ shopify-cli git:(m1-support) ✗ lipo -info ~/.cache/shopify/ngrok Non-fat file: /Users/stevemartinelli/.cache/shopify/ngrok is architecture: arm64
The old version was not
➜ test-m1 git:(m1-support) ✗ lipo -info ~/.cache/shopify_bak/ngrok Non-fat file: /Users/stevemartinelli/.cache/shopify_bak/ngrok is architecture: x86_64
Update checklist